Merged
Conversation
This matches the behavior of populate __environ. See #27
Member
|
Makes sense. The alternative here is to say that it's always the WASI implementation's job to add the NULL terminator, however doing it in crt1.c here is simpler for non-C-family languages that don't require the NULL terminator, so let's go with that. |
sunfishcode
added a commit
to bytecodealliance/wasmtime
that referenced
this pull request
May 30, 2019
The wasm userspace has been updated to do that instead, in WebAssembly/wasi-libc#72.
kubkon
pushed a commit
to bytecodealliance/wasmtime
that referenced
this pull request
Jun 2, 2019
The wasm userspace has been updated to do that instead, in WebAssembly/wasi-libc#72.
tschneidereit
pushed a commit
to tschneidereit/wasmtime
that referenced
this pull request
Jun 25, 2019
The wasm userspace has been updated to do that instead, in WebAssembly/wasi-libc#72.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matches the behavior of populate __environ.
See WebAssembly/WASI#27