don't mark just-connected socket ready-to-read in poll(2)#732
Merged
alexcrichton merged 2 commits intoWebAssembly:mainfrom Feb 11, 2026
Merged
don't mark just-connected socket ready-to-read in poll(2)#732alexcrichton merged 2 commits intoWebAssembly:mainfrom
poll(2)#732alexcrichton merged 2 commits intoWebAssembly:mainfrom
Conversation
Collaborator
|
CI looks mostly realted to failing to build the test on WASIp1 in which case it's fine to |
Contributor
Author
|
Yup, looking into it. I didn't think |
This fixes a bug in the `poll(2)` implementation for `wasm32-wasip2` such that it spuriously set the `POLLRDNORM` bit on the `revents` field for a socket which just finished connecting even though there's nothing immediately available to read. The fix is to set at most the `POLLWRNORM` bit in that situation.
dicej
force-pushed
the
fix-poll-spurious-read-readiness
branch
from
45b974a to
bed501a
Compare
alexcrichton
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the
poll(2)implementation forwasm32-wasip2such that it spuriously set thePOLLRDNORMbit on thereventsfield for a socket which just finished connecting even though there's nothing immediately available to read. The fix is to set at most thePOLLWRNORMbit in that situation.