wasip2: Deduplicate stream code in read/write/TCP#735
Open
alexcrichton wants to merge 2 commits intoWebAssembly:mainfrom
Open
wasip2: Deduplicate stream code in read/write/TCP#735alexcrichton wants to merge 2 commits intoWebAssembly:mainfrom
alexcrichton wants to merge 2 commits intoWebAssembly:mainfrom
Conversation
This commit extends the support in WebAssembly#734 by deduplicating the separate paths for reading a stream shared between `read` and `recvfrom`, for example. The `get_{read,write}_stream` methods now return more metadata and the TCP `recvfrom` implementation delegates to an internal `__wasilibc_read` to perform the actual read. This opens up the door to supporting nonblocking reads/writes on other streams in the future, for example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit extends the support in #734 by deduplicating the separate paths for reading a stream shared between
readandrecvfrom, for example. Theget_{read,write}_streammethods now return more metadata and the TCPrecvfromimplementation delegates to an internal__wasilibc_readto perform the actual read. This opens up the door to supporting nonblocking reads/writes on other streams in the future, for example.