report read readiness accurately for freshly bound UDP sockets#740
Merged
alexcrichton merged 1 commit intoWebAssembly:mainfrom Feb 13, 2026
Merged
Conversation
Previously, `wasip2_udp.c` would call `wasi:sockets/udp#udp-socket.streams` lazily as needed in e.g. `sendto` and `recvfrom`. However, it was not doing so when the socket was `poll`ed, which meant `poll` would indicate read readiness and return immediately even though there was nothing ready to read. With this commit, we now create the stream when polling the socket, which allows us to actually wait for real read readiness. This also adds trivial `SO_ERROR` support to `udp_getsockopt`.
dicej
force-pushed
the
wasip2-udp-fresh-bound-read-readiness
branch
from
d20381f to
9681c68
Compare
alexcrichton
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
wasip2_udp.cwould callwasi:sockets/udp#udp-socket.streamslazily as needed in e.g.sendtoandrecvfrom. However, it was not doing so when the socket waspolled, which meantpollwould indicate read readiness and return immediately even though there was nothing ready to read.With this commit, we now create the stream when polling the socket, which allows us to actually wait for real read readiness.
This also adds trivial
SO_ERRORsupport toudp_getsockopt.