Do not use GNU find features on FreeBSD#345
Merged
sunfishcode merged 1 commit intoWebAssembly:mainfrom Sep 6, 2023
kiancross:free-bsd-fix
Merged
Do not use GNU find features on FreeBSD#345sunfishcode merged 1 commit intoWebAssembly:mainfrom kiancross:free-bsd-fix
sunfishcode merged 1 commit intoWebAssembly:mainfrom
kiancross:free-bsd-fix
Conversation
FreeBSD (like MacOS) does not support the `-executable` argument for `find`. This commit checks if the OS is FreeBSD, and if so, uses the same workaround as already in place on MacOS.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FreeBSD (like MacOS) does not support the
-executableargument forfind. This commit checks if the OS is FreeBSD, and if so, uses the same workaround as already in place on MacOS.A more portable solution might be to test if the
-executableflag is available, and fallback to-permif not.