Fix installation and usage instructions in README.md#488
Merged
abrown merged 4 commits intoWebAssembly:mainfrom Sep 18, 2024
seclerp:seclerp/fix-installation-script
Merged
Fix installation and usage instructions in README.md#488abrown merged 4 commits intoWebAssembly:mainfrom seclerp:seclerp/fix-installation-script
abrown merged 4 commits intoWebAssembly:mainfrom
seclerp:seclerp/fix-installation-script
Conversation
sbc100
reviewed
Sep 17, 2024
sbc100
approved these changes
Sep 17, 2024
Member
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
Can you update the title to mention that this is an update the readme. Something like: "Fix installation and usage instruction in README.md"?
seclerp
changed the title
abrown
approved these changes
Sep 17, 2024
yamt
reviewed
Sep 18, 2024
Co-authored-by: Andrew Brown <andrew.brown@intel.com>
abrown
approved these changes
Sep 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I just tried the installation scripts for the GitHub workflow and it seems like the release artifacts layout has been changed a bit, so installation and usage shell scripts need a little update.