[ci] Install cmake and ninja from apt ci Dockerfile#516
Draft
mcbarton wants to merge 1 commit intoWebAssembly:mainfrom
Draft
[ci] Install cmake and ninja from apt ci Dockerfile#516mcbarton wants to merge 1 commit intoWebAssembly:mainfrom
mcbarton wants to merge 1 commit intoWebAssembly:mainfrom
Conversation
Contributor
Author
|
Not sure why my PR caused apt to now require the geographic location. Will convert to draft until I work out why |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the ci Dockerfile it says cmake and ninja are fetched from Github releases since Ubuntu 18.04 doesn't have a new enough version to build llvm. The Dockerfile now uses Ubuntu 20.04, so this might no longer be needed, and these can be got from apt, simplifying the Dockerfile.