Merged
Conversation
404f741 to
73e9ec8
Compare
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
* Don't build the target by default yet * Build a separate compiler-rt for updated ABI eventually
73e9ec8 to
48fe4e3
Compare
alexcrichton
approved these changes
Mar 3, 2026
Collaborator
alexcrichton
left a comment
There was a problem hiding this comment.
I've pushed a few changes here to help this land:
- I rebased this on
mainand handled conflicts - The
wasm32-wasip3target is off-by-default (not included in the default list) - A separate compiler-rt build is done to handle the different ABI of wasip3 in the future.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build
wasip3targetRequires #592There's a lot of failing tests currently, so we'll probably want to rebase this PR as we pull in more recent versions of
wasi-libcand merge once tests pass