export memory for the C wasi-threads test module#100
Merged
loganek merged 1 commit intoWebAssembly:mainfrom Aug 12, 2024
Merged
export memory for the C wasi-threads test module#100loganek merged 1 commit intoWebAssembly:mainfrom
loganek merged 1 commit intoWebAssembly:mainfrom
Conversation
wasi requires the memory exported as "memory". certain runtimes actually requires it. (eg. wasmtime) cf. WebAssembly/wasi-sdk#297 also, bump the wasi-sdk version because this doesn't work with an old wasm-ld.
yamt
added a commit
to yamt/toywasm
that referenced
this pull request
Aug 10, 2024
yamt
added a commit
to yamt/toywasm
that referenced
this pull request
Aug 10, 2024
loganek
approved these changes
Aug 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wasi requires the memory exported as "memory".
certain runtimes actually requires it. (eg. wasmtime)
cf. WebAssembly/wasi-sdk#297
also, bump the wasi-sdk version because this doesn't work with an old wasm-ld.