add a few test cases with fd_read#41
Merged
loganek merged 2 commits intoWebAssembly:mainfrom Apr 7, 2023
Merged
Conversation
Contributor
Author
loganek
reviewed
Mar 22, 2023
| @@ -0,0 +1,58 @@ | |||
| ;; When the main thread calls proc_exit, it should terminate | |||
| ;; a thread blocking in a WASI call. (poll_oneoff) | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| ;; a thread blocking in a WASI call. (poll_oneoff) | |
| ;; a thread blocking in a WASI call. (fd_read) |
Contributor
Author
There was a problem hiding this comment.
oops, fixed. thank you.
a fix for toywasm: yamt/toywasm@e9cc8ce wamr doesn't work as of writing this. it might be fixed when dev/interrupt_block_insn branch is done.
Contributor
Author
Collaborator
|
Sorry for the delay. The change looks good to me. @abrown / anybody else: I'll go ahead and merge it as the PR was open for quite some time; feel free to open an issue if you have any comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a fix for toywasm: yamt/toywasm@e9cc8ce
wamr doesn't work as of writing this.
it might be fixed when dev/interrupt_block_insn branch is done.