Skip to content
This repository was archived by the owner on Aug 22, 2022. It is now read-only.

Run npm install before running emscripten tests #618

Merged
sbc100 merged 2 commits into from
Jan 27, 2020
Merged

Run npm install before running emscripten tests #618

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8baead
Run `npm install` before running emscripten tests
sbc100 Jan 27, 2020
35a6ca3
flake8
sbc100 Jan 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1615,6 +1615,8 @@ def ExecuteEmscriptenTestSuite(name, tests, config, outdir, warn_only=False):
buildbot.Step('Execute emscripten testsuite (%s)' % name)
Mkdir(outdir)
try:
proc.check_call([os.path.join(NodeBinDir(), 'npm'), 'install'],
Copy link
Member

@dschuff dschuff Jan 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also. does this need to be wrapped in Executable()?

Copy link
Member Author

@sbc100 sbc100 Jan 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup .. I think so.

cwd=GetInstallDir('emscripten'))
proc.check_call(
[GetInstallDir('emscripten', 'tests', 'runner.py'),
'--em-config', config] + tests,
Expand Down