Add a version of Angrybots with most of the 0xc changes.#13
Closed
sunfishcode wants to merge 1 commit intomasterfrom
Closed
Add a version of Angrybots with most of the 0xc changes.#13sunfishcode wants to merge 1 commit intomasterfrom
sunfishcode wants to merge 1 commit intomasterfrom
Conversation
This adds 0xc changes, except block signatures. Changes: - converted loops to not use their exit label - updated indirect_call operand order to put the callee last - inserted a gratuitous dependence on stack-machine rules (see the very first set_local) - inserted a gratuitous use of branch-to-function scope - optimized away unnecessary `blocks` - new "flat" text format
Member
|
Do you want me to update the instantiation code to check for 0xC support and use this? Or should we wait to merge this until block signatures are added? |
Member
Author
|
I think we should wait until block signatures are in. I posted this now because people expressed interested in it, but I hope to find time to add block signatures before long. |
Member
Author
|
This PR is now subsumed by https://github.com/WebAssembly/webassembly.github.io/pull/14 which includes block signatures and also section opcodes, and also a candidate binary image. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds 0xc changes, except block signatures.
Changes:
first set_local)
blocks