Add more data to the feature table#292
Merged
RReverser merged 4 commits intoWebAssembly:mainfrom Jan 11, 2023
Merged
Conversation
Member
|
Looks like it's still up to me to review those 😅 Can you please rebase to fix the conflict and I'll merge? (I can fix it myself but not sure which |
Member
|
Resolved to 1080px, hope that's ok. |
Member
|
Wait, I only just noticed that this removed information about specific V8 flags. I don't agree it was redundant as now it only conveys "how to pass a flag to the engine" instead of the more useful "which flag to pass to the engine for this feature" and users have to go hunting for actual flags in engine docs. Also Wasmtime doesn't support threads yet despite having a flag - they're simply not part of the WASI yet. (which is actually true for Wasmer too, so I'll remove it) I restored those flags on the |
Member
|
Wow this is a great update, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've collected a bunch of version data for the feature table.
Wasmtime
Wasmer
I'm unable to find the versions for some old proposals like sign extensions and saturating f2i conversions. The relevant logic in both wasmer and wasmtime was refactored a lot since then, I'm unable to trace it back enough to confidently say which versions were they first introduced.
V8
Node.js
v8 -> nodeversion data from https://nodejs.org/en/download/releases/.Deno
v8 -> rusty_v8 -> denoversion data from release notes and (sometimes) git history.rusty_v8VersionI've also changed the tooltips for v8 flags. Before, we would need to write three tooltips for the three "wrappers" of v8, for every feature flag of v8, like so:
--experimental-wasm-memory64(node)--v8-flags="--experimental-wasm-memory64"(deno)--js-flags=--experimental-wasm-memory64(chrome)--experimental-wasm-extended-const--v8-flags="--experimental-wasm-extended-const"--js-flags=--experimental-wasm-extended-constThis feels quite redundant to me, so I changed them to:
--v8-flags="...") (deno)--js-flags="...") (chrome)By the way, is the Module Linking proposal still relevant today? From what I can tell, it was superseded by the Component Model. Should I replaced it with data from component model?