Skip to content

Update Chrome's support of type reflection, v2 #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RReverser merged 1 commit into from
Jan 12, 2023
Merged

Update Chrome's support of type reflection, v2 #301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions features.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@
"signExtensions": "74",
"simd": "91",
"tailCall": ["flag", "Requires flag `chrome://flags/#enable-experimental-webassembly-features`"],
"threads": "74"
"threads": "74",
"typeReflection": ["flag", "Requires flag `chrome://flags/#enable-experimental-webassembly-features`"],
Copy link
Contributor

@andylizi andylizi Jan 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the new version has been deployed, the trailing comma here is breaking the site:

SyntaxError: Expected double-quoted property name in JSON at position 3936

Copy link
Member

@RReverser RReverser Jan 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed.

}
},
"Firefox": {
Expand Down Expand Up @@ -193,7 +194,7 @@
"simd": "16.4",
"tailCall": ["flag", "Requires flag `--experimental-wasm-return-call`"],
"threads": "16.4",
"typeReflection": ["flag", "Requires corresponding v8 flag"]
"typeReflection": ["flag", "Requires flag `--experimental-wasm-type-reflection`"]
}
},
"Deno": {
Expand Down