Skip to content

Update Wasmtime's available features and how they are accessed #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 1 commit into from
Feb 7, 2023
Merged

Update Wasmtime's available features and how they are accessed #313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions features.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,15 +152,15 @@
"features": {
"bigInt": null,
"bulkMemory": "0.20",
"memory64": ["flag", "Requires flag `--enable-memory64`"],
"multiMemory": ["flag", "Requires flag `--enable-multi-memory`"],
"memory64": ["flag", "Requires flag `--wasm-features=memory64`"],
"multiMemory": ["flag", "Requires flag `--wasm-features=multi-memory`"],
"multiValue": "0.17",
"mutableGlobals": true,
"referenceTypes": "0.20",
"saturatedFloatToInt": true,
"signExtensions": true,
"simd": "0.33",
"threads": null
"threads": ["flag", "Requires flag `--wasm-features=threads`"],
Copy link
Contributor

@andylizi andylizi Feb 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

SyntaxError: Expected double-quoted property name in JSON at position 5855

The trailing comma is breaking the site.

Copy link
Member

@sbc100 sbc100 Feb 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, lets revert.

Copy link
Contributor Author

@abrown abrown Feb 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I opened #315 that solely fixes the flag syntax. Let's figure out what to do about the thread proposal line below...

}
},
"Wasmer": {
Expand Down