This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Merged
Conversation
Added ReadLine
But fail to compile with old interface
Forgot to supply type arguments.
Added WasiResult Class
Moved classes to their own files/folders. Changed name to better describe the test fixture class.
Also path passes more tests
Also updated types and added error handling for reading and writing to a file.
Also can delete files and folders. Need to parse json to create test directory.
And more documentation for types.
[skip ci]
Also can import fs structure from a json string.
Add error checking and more tests.
Now tests don't need to import globals.
Also added Environ class to the global scope.
* Fix bug with how files and strings are terminated Now readString and readLine will return null if reading a terminating char like EOF. * Fixed Seek END to be relative to size not length
* Added WasiResult to globals in tests * Fixed off by one error for reading and writing When reading a string new offset included NUL. Writing also included a null, which it shouldn't.
willemneal
added a commit
that referenced
this pull request
May 15, 2019
This reverts commit 13e0b71.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.