Fix WebAudio/web-audio-api-v2#13: User-selectable render size#2369
Fix WebAudio/web-audio-api-v2#13: User-selectable render size#2369rtoy wants to merge 2 commits intoWebAudio:mainfrom
Conversation
|
This is a draft of the changes for user-selectable render size. I'm kind of stuck right now because I don't know how to handle adding the new Also see speced/bikeshed#2109 |
hoch
left a comment
hoch
left a comment
There was a problem hiding this comment.
IMO using string literal comes with many benefits, but we can update it with a follow-up PR.
| Changes Since Recommendation of 17 Jun 2021 | ||
| </h3> | ||
| * <a href="https://github.com/WebAudio/web-audio-api-v2/issue/13">V2 Issue 13</a>: User-selectable render size | ||
| <div id="change-list-a13"> |
There was a problem hiding this comment.
Just curious: what's this div for?
| </span> | ||
| Categories for user-selectable render size. | ||
| <div class="amendment-buttons"> | ||
| Buttons here |
There was a problem hiding this comment.
I guess this "Buttons here" text will be replaced by scripts?
| let text = ""; | ||
| if (changeNum > 1) { | ||
| // Add "previous" button, only if there is a previous change. | ||
| text += "<button onclick='location.href="; |
There was a problem hiding this comment.
nit: I think it's better to use string literal than concatenation.
|
|
||
| if (document.getElementById(changeID + "-" + (changeNum + 1))) { | ||
| // Add "next" button only if there is a next change | ||
| text += "<button onclick='location.href="; |
|
I am not sure if someone can take over this draft. If not, we should close and revisit later. |
|
Closing this in favor of #2469. |
2 participants
Preview | Diff