Speech api backport #854
Merged
Speech api backport #854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tested both changes with custom PlatformSpeechSynthesiser and basic use-cases seem to work fine. |
asurdej-comcast
approved these changes
May 20, 2022
asurdej-comcast
approved these changes
May 20, 2022
Allows compilation with SPEECH_SYNTHESIZER enabled, to check for build failures when backporting patches using this feature.
From c8a7a86 upstream commit.
lauromoura
force-pushed
the
speech-error-event-backport
branch
from
1829f64 to
c358177
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports upstream c8a7a86 alongside a commit with a stub
PlatformSpeechSynthesizerGlib.cppto be able to compile the backported code with just the WPEWebKit repo.cc @asurdej-comcast