Allow PlatformSpeechSynthesiser to report error code on failure #863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend speakingErrorOccurred() of PlatformSpeechSynthesizerClient with SpeechError code that reflects the source of failure.
asurdej-comcast
force-pushed
the
speach_synth_err_event
branch
from
dc10130 to
5e8196f
Compare
Author
|
@lauromoura Would you mind reviewing this? |
lauromoura
approved these changes
Jun 3, 2022
lauromoura
left a comment
lauromoura
left a comment
There was a problem hiding this comment.
Looks good.
I think this could be added upstream too, so I'll rebase it on top of upstream, fixing the conflicts and linking to this PR for reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend speakingErrorOccurred() of PlatformSpeechSynthesizerClient
with SpeechError code that reflects the source of failure.