This repository was archived by the owner on Jul 3, 2024. It is now read-only.
Deprecate Interop\Container\ContainerInterface #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting Feb. 13th 2017, container-interop is officially deprecated in favor of PSR-11. Given that the Interop's readme starts off with the statement above, then it makes sense to deprecate the package in favour of Psr\Container\ContainerInterface, which this change implements. I was motivated to make the change as I'm trying to use the package with a small Slim Framework project I'm working on, and was restricted from doing so, because of the project using Interop\Container\ContainerInterface. After doing a bit of hunting, I came across the above statement in the README, so decided to create this change.
Collaborator
|
@settermjd Thanks for the PR! |
Contributor
Author
|
Thanks for merging it, @roelvanduijnhoven. Sorry for not responding sooner. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that ContainerInterop's README starts off with the statement above, then it makes sense to deprecate the package in favour of
Psr\Container\ContainerInterface, which this change does.