Closed
Conversation
1 task
Owner
|
I actually wasn't aware of |
Contributor
Author
|
I'm about to push a PR. Waiting for all checks to pass. |
Contributor
Author
|
Passed test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another attempt at a fix for Cast to int format error (Format function no longer accepts enums) #166
Took me a few goes to get this. In the end it was pretty simple. Hope it works. It does for me.
The usual disclaimers. I don't know the code base well, etc...
It does smell a bit hacky, but by far the the simplest solutuon out of the ones I tired. Perhaps a better one would be to use enable_shared_from_this on the Pattern class. This would requite that
Patternis mangaged be ashared_ptr.I have added as PR for second method. I prefer this one, although both work.