Skip to content

fix(qdt profile): plugin_id should be an int #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmkerloch merged 2 commits into from
Mar 26, 2025
Merged

fix(qdt profile): plugin_id should be an int #49

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e5309a
fix(qdt profile): plugin_id should be an int
jmkerloch Feb 13, 2025
8529f53
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions profile_manager/profiles/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ class PluginInformation:
name: str
folder_name: str
official_repository: bool
plugin_id: str
plugin_id: Optional[int]
version: str


Expand Down Expand Up @@ -193,7 +193,11 @@ def get_profile_plugin_information(
name=manager_metadata["name"],
folder_name=plugin_slug_name,
official_repository=True, # For now we only support official repository
plugin_id=manager_metadata["plugin_id"],
plugin_id=(
int(manager_metadata["plugin_id"])
if manager_metadata["plugin_id"]
else None
),
version=define_plugin_version_from_metadata(
manager_metadata=manager_metadata,
plugin_metadata=plugin_metadata,
Expand Down Expand Up @@ -221,7 +225,7 @@ def get_profile_plugin_list_information(

for plugin_name in plugin_list:
plugin_info = get_profile_plugin_information(profile_name, plugin_name)
if plugin_info and plugin_info.plugin_id != "":
if plugin_info and plugin_info.plugin_id:
profile_plugin_list.append(plugin_info)

return profile_plugin_list
Loading