Skip to content

Conversation

@Guts
Copy link
Collaborator

@Guts Guts commented Mar 26, 2025

Render:

Capture.video.du.2025-03-26.18-34-45.mp4

❤️ Funded by Oslandia

@github-actions github-actions bot added documentation Improvements or additions to documentation ci-cd Intégration et déploiement continus (GitHub Action, Workflow) dependencies Pull requests that update a dependency file UI User interface: forms, widgets... labels Mar 26, 2025
@Guts Guts requested review from jmkerloch and kannes March 26, 2025 17:24
@Guts Guts force-pushed the docs/integrate-contributing-guidelines-and-changelog branch from 7222c6d to 1fd3787 Compare March 26, 2025 17:24
@kannes
Copy link
Contributor

kannes commented Mar 28, 2025

Ooh fancy, thank you! That looks great :)

Action safety

I am a bit scared by the third-party action uses: dawidd6/action-download-artifact@v9

From what I learned, this is not safe as it is only referencing a version, not a commit hash. That way the author (or a malicious actor who got access to the author's repo) could publish a malicious v9. Crafting a SHA1 collision is possible too but harder and I doubt someone would go that length if they could own vX people more easily.

Could you specify a specific git commit instead?

(I was hoping that action was easy to review but it is three gazillion node packages. I guess we can assume that it is currently safe to use though... :} )

@Guts
Copy link
Collaborator Author

Guts commented Mar 28, 2025

I get your point but it sounds to me an overkill security safety since it only manipulate documentation files with no content write and no access to secrets. Well it could publish on GH Pages.

Nevertheless, I've changed to the commit hash.

@Guts Guts force-pushed the docs/integrate-contributing-guidelines-and-changelog branch from affc476 to ca23f88 Compare March 28, 2025 18:37
Copy link
Collaborator

@jmkerloch jmkerloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now just have to add the documentation for the plugin use 😄

@kannes
Copy link
Contributor

kannes commented Mar 31, 2025

I get your point but it sounds to me an overkill security safety since it only manipulate documentation files with no content write and no access to secrets. Well it could publish on GH Pages.

Nevertheless, I've changed to the commit hash.

Now you know how much I know about actions and permissions ;D
Better safe than sorry though!

Thank you

@kannes
Copy link
Contributor

kannes commented Mar 31, 2025

Would it make sense to update the homepage in metadata.txt to this? I'd like that :)

@Guts
Copy link
Collaborator Author

Guts commented Mar 31, 2025

Now you know how much I know about actions and permissions ;D
Better safe than sorry though!

No worries, your project, your rules and indeed it's wiser than the reverse :).

Would it make sense to update the homepage in metadata.txt to this? I'd like that :)

Good idea! Done in latest commit!

@Guts Guts merged commit 031f378 into main Mar 31, 2025
6 checks passed
@Guts Guts deleted the docs/integrate-contributing-guidelines-and-changelog branch March 31, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-cd Intégration et déploiement continus (GitHub Action, Workflow) dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation UI User interface: forms, widgets...

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants