Clean up and fixes #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Line lengths, too much whitespace, coding headers, unused imports, etc
was broken anyways, missing trailing 0 in the number :o)
- DataSourceProvider: Document functions - InterfaceHandler: remove vars and parser, merge functions
- Signals were connected multiple times - Selection of active profile triggered cascade of UI updates
There is no standard or rules that provide a safe way to identify plugins' options... ref: https://hannes.enjoys.it/blog/2023/07/plugins-in-qgis3-ini/
Also improve names and method signatures in DataSourceProvider This makes using the parsers less error-prone (no need to call .clear()) and makes following the code much easier (no need to track what ini file a instance variable parser might have changed to).
Use paths to profiles as common parameter standard, so that the functions themselves handle the information as to where THEIR relevant information is stored and how to access it. TODO: - Plugins - Data source connections
Contributor
Author
|
Current state is a mixed-bag as I had to jump projects midway:
|
8 tasks
Contributor
Author
|
This was left with broken parts, at least transfer of data sources and bookmarks does not work at the moment. To not halt development and contributions, let's merge it anyways. The main version of the plugin had its own issues (silent failures, missing something things, etc) so while this makes things a bit worse in terms of usability for now, it provides a better base for future development and fixes. 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of changes, following a dive into the code in preparation of the plugin leaving the "experimental" state.
Some cosmetics, some refactoring, some fixes, some new features. This branch is meant for testing, not code review.
When merging
mainthe work from #6 was overwritten because it was not necessary anymore.