Skip to content

Add some padding around extent when zooming to filter geometry #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kannes merged 2 commits into from
Jul 18, 2023
Merged

Add some padding around extent when zooming to filter geometry #22

kannes merged 2 commits into from
Jul 18, 2023

Conversation

@pathmapper
Copy link
Contributor

@pathmapper pathmapper commented Jun 9, 2023

closes #17

The amount of padding is also a matter of taste, so please feel free to suggest a different factor 😉

This PR:
grafik

Before:
grafik

pathmapper
pathmapper commented Jun 10, 2023
View reviewed changes
kannes
kannes approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@kannes kannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you!

@kannes kannes merged commit 1868d4b into WhereGroup:main Jul 18, 2023
@pathmapper pathmapper deleted the padding branch July 18, 2023 10:46
@pathmapper
Copy link
Contributor Author

pathmapper commented Jul 18, 2023

Thanks for the review!

pgipper added a commit that referenced this pull request Aug 24, 2024
@pgipper
Merge branch 'auto_activate_filter' into 'main'
fb3131f 
auto_activate_filter

Closes #17, #21, and #22

See merge request qgis/hvbg-filterplugin!12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kannes kannes kannes approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add some padding around extent when zooming to filter geometry

2 participants

@pathmapper @kannes