Refactored and implemented bitcoin connector#23
Merged
cristianvanderwey merged 1 commit intodev/bitcoinfrom Jul 27, 2021
Merged
Refactored and implemented bitcoin connector#23cristianvanderwey merged 1 commit intodev/bitcoinfrom
cristianvanderwey merged 1 commit intodev/bitcoinfrom
Conversation
ts5746
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split the bitcoin connector in several services for maintainabilit
-bitcoinAccountService
-bitcoinRpcService
-bitcoinTransactionService
-bitcoinUtxoService
Added the necessary functions to send OP_RETURN messages, send transactions and scan for UTXO's:
Added functionality to synchronize accounts and track latest blocknumber on startup.
TODO
-Transaction id tracking to make sure the transaction is submitted to the blockchain
-Specify blocks where utxos are located for a new account so that not the whole blockchain needs to be searched for utxo's