Different queue for each voice channel#42
Merged
Conversation
Wikijito7
requested changes
Mar 13, 2024
Wikijito7
requested changes
Mar 14, 2024
Owner
Wikijito7
left a comment
There was a problem hiding this comment.
Waiting for new tests in dev execution between servers to merge.
Owner
|
Crash after adding a lot of sounds to queue and then leaving without finishing it to add them while being connected on voice channel. |
Owner
|
When adding a new video, it may block the thread enough time to execute skip and make the bot disconnect with sounds on the queue as it is marked as ready to be removed but there are content on the queue. We should double check if the bot was marked as ready to remove but there are content (that may happen) and remove this state in order to mantain it playing. |
# Conflicts: # voice.py
This was referenced Mar 27, 2024
Owner
|
This branch will be merged to solve errors from main branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now each guild (server) has its very own sound queue, and multiple guilds can listen to the bot simultaneously.