Skip to content

Conversation

@WilliamBergamin
Copy link
Owner

(Describe the goal of this PR. Mention any related Issue numbers)

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

This is all POC

- Added the get-hooks hook
- Added the get manifest hook
- Added the start hook
Opted to use python module run over entry_points to simplify code
Adding console script for the get-hook hook increases backward compatibility since the user does not require path knowledge
Can accept functions and return the payload properly, missing tests, error handling and async capabilities
The functions can now respond to the event as an error if an excpetion occured in the code
added more tests and added code clearity
the sync function listener should now be fully tested
Renamed some directories and relocated the cli error
Added types to cli portion of the project

Added search in project capability to get_manifest hook
@WilliamBergamin WilliamBergamin merged commit e95bf15 into future Aug 26, 2022
@WilliamBergamin WilliamBergamin deleted the future-function-interactivity branch August 26, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants