Skip to content

Fixes for unpick (and adapt to V4)#36

Merged
WinPlay02 merged 3 commits intoWinPlay02:masterfrom
0x189D7997:fix-unpick
Dec 3, 2025
Merged

Fixes for unpick (and adapt to V4)#36
WinPlay02 merged 3 commits intoWinPlay02:masterfrom
0x189D7997:fix-unpick

Conversation

@0x189D7997
Copy link
Contributor

Unpick V4 requires newly introduced class member checker to be set when building a DataDrivenGrouper.

Said member checker can be obtained in a the same way as an inheritance checker and this is what did I here. I am not too familiar with unpick so this might be not the right way to do it but it seems to work and pass all the tests.
Needs to be sanity checked by someone with better understanding of matter.

@0x189D7997 0x189D7997 changed the title Fix crash when using unpick (adapt to V4) Fixes for unpick (and adapt to V4) Nov 13, 2025
@0x189D7997 0x189D7997 marked this pull request as draft November 13, 2025 13:29
@0x189D7997
Copy link
Contributor Author

There is one mode issue I'd like to fix here.
When one or more of the requested versions do not have the chosen or fallback unpick (and fallback does not include none) the applications hangs indefinitely.

I'd like to do this by excluding versions that do not meet unpick requirements, however there are two more approaches I can think of:

  • Have none as the default fallback
  • Crash before doing anything if this happens.

I'm going with excluding versions like mappings do but I can implement a different approach if needed,

@0x189D7997 0x189D7997 marked this pull request as ready for review November 14, 2025 23:06
@0x189D7997
Copy link
Contributor Author

@WinPlay02 can you please re-run CI for this one?
The new fail is inconsistent and is not caused by the changes.
Possibly because we are sending too many requests to Skyrising host and hit some sort of rate limit. #40 might help with this.

Also, there is no point of running CI on any other PRs until this one is merged.

Copy link
Owner

@WinPlay02 WinPlay02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this

@WinPlay02 WinPlay02 merged commit e8cbbb8 into WinPlay02:master Dec 3, 2025
1 of 2 checks passed
@0x189D7997 0x189D7997 deleted the fix-unpick branch December 9, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants