Fixes for unpick (and adapt to V4)#36
Conversation
|
There is one mode issue I'd like to fix here. I'd like to do this by excluding versions that do not meet unpick requirements, however there are two more approaches I can think of:
I'm going with excluding versions like mappings do but I can implement a different approach if needed, |
|
@WinPlay02 can you please re-run CI for this one? Also, there is no point of running CI on any other PRs until this one is merged. |
WinPlay02
left a comment
There was a problem hiding this comment.
Thanks for taking care of this
Unpick V4 requires newly introduced class member checker to be set when building a
DataDrivenGrouper.Said member checker can be obtained in a the same way as an inheritance checker and this is what did I here. I am not too familiar with unpick so this might be not the right way to do it but it seems to work and pass all the tests.
Needs to be sanity checked by someone with better understanding of matter.