Improve MetadataProvider.getVersions(...) logic#46
Merged
WinPlay02 merged 6 commits intoWinPlay02:masterfrom Dec 21, 2025
Merged
Improve MetadataProvider.getVersions(...) logic#46WinPlay02 merged 6 commits intoWinPlay02:masterfrom
MetadataProvider.getVersions(...) logic#46WinPlay02 merged 6 commits intoWinPlay02:masterfrom
Conversation
…ng versions [no ci]
0x189D7997
added a commit
to 0x189D7997/GitCraft
that referenced
this pull request
Dec 18, 2025
WinPlay02
approved these changes
Dec 21, 2025
Owner
WinPlay02
left a comment
WinPlay02
left a comment
There was a problem hiding this comment.
Thanks for taking care of this. Other than the tests that needed adjustment, this looks good
Contributor
Author
|
@WinPlay02 I am sorry for not taking care of tests myself, I didn't want to overuse CI and forgot to account for this. There is still a smaller issue with them, when ran individually, some tests such as Edit: I opened #47 for this. |
0x189D7997
added a commit
to 0x189D7997/GitCraft
that referenced
this pull request
Dec 23, 2025
WinPlay02
added a commit
that referenced
this pull request
Dec 23, 2025
Additional fixes for tests after #46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #31, calling
MetadataProvider.getVersions(Executor)with null executor when assuming the versions are already loaded can potentially cause a hard-to-trace exception.This PR adds
getVersionsAssumeLoaded()variant specifically for this use case which fails explicitly if called before versions are loaded. The executor ininitializeAndLoadVersions(Executor)is also checked for beingnullandversionsLoadedflag is now set only after all loading steps are complete for thread safety.