Skip to content
This repository was archived by the owner on Nov 14, 2017. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions _template.html
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,14 @@
<li><a href="projects.html#java">Java SDK</a></li>
<li><a href="projects.html#php">PHP SDK</a></li>
<li><a href="projects.html#python">Python SDK</a></li>
<li class="divider"></li>
<li class="nav-header">Command line</li>
<li><a href="projects.html#powershell">PowerShell</a></li>
<li><a href="projects.html#cli">x-plat CLI</a></li>
<li class="divider"></li>
<li class="nav-header">More Projects</li>
<li><a href="projects.html#iisnode">iisnode</a></li>
<li><a href="projects.html#teams">Other teams</a></li>
<li class="divider"></li>
<li class="nav-header">WindowsAzure.com</li>
<li><a href="//www.windowsazure.com/en-us/documentation/">Documentation Center</a></li>
Expand Down
5 changes: 5 additions & 0 deletions contact.html
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,13 @@
<li><a href="projects.html#php">PHP SDK</a></li>
<li><a href="projects.html#python">Python SDK</a></li>
<li class="divider"></li>
<li class="nav-header">Command line</li>
<li><a href="projects.html#powershell">PowerShell</a></li>
<li><a href="projects.html#cli">x-plat CLI</a></li>
<li class="divider"></li>
<li class="nav-header">More Projects</li>
<li><a href="projects.html#iisnode">iisnode</a></li>
<li><a href="projects.html#teams">Other teams</a></li>
<li class="divider"></li>
<li class="nav-header">WindowsAzure.com</li>
<li><a href="//www.windowsazure.com/en-us/documentation/">Documentation Center</a></li>
Expand Down
6 changes: 5 additions & 1 deletion css/azureopensource.css
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,12 @@ h1 {
top: 40px;
}

.small-sections section {
padding-top: 6px;
}

section {
padding-top: 30px;
padding-top: 42px;
}

.twitter-cards > tbody > tr > td > h4,
Expand Down
31 changes: 30 additions & 1 deletion guidelines.html
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,13 @@
<li><a href="projects.html#php">PHP SDK</a></li>
<li><a href="projects.html#python">Python SDK</a></li>
<li class="divider"></li>
<li class="nav-header">Command line</li>
<li><a href="projects.html#powershell">PowerShell</a></li>
<li><a href="projects.html#cli">x-plat CLI</a></li>
<li class="divider"></li>
<li class="nav-header">More Projects</li>
<li><a href="projects.html#iisnode">iisnode</a></li>
<li><a href="projects.html#teams">Other teams</a></li>
<li class="divider"></li>
<li class="nav-header">WindowsAzure.com</li>
<li><a href="//www.windowsazure.com/en-us/documentation/">Documentation Center</a></li>
Expand Down Expand Up @@ -543,10 +548,34 @@ <h4>Create bug fixes and features<br>

<section id="codereviews">
<h2>Code Reviews</h2>
<p>
The Windows Azure SDK team has an active Microsoft discussion
group used for submitting code reviews and discussing design
changes, best practices, and other important topics.
</p>
<p>
Part of the code review process involves using a code review
tool, and for most open source projects, the team uses the
built-in Pull Request functionality on GitHub for enabling
annotations and comments on code before accepting the pull
request/s.
</p>
<p>
Expect a good amount of feedback as part of any pull request:
not only which branch to merge to and from, but also
consistency guidelines, matching existing code, and
making targeted, smart changes when fixing bugs.
</p>

<h3>Community code reviews</h3>
<p>
tbd
The SDK team is considering allowing for community code
reviews as well. If you watch a repository of interest,
you can make comments on any public pull request. The
best time for providing feedback is during dev branch
pulls into the primary WindowsAzure GitHub account.
</p>

</section>

<section id="contact">
Expand Down
5 changes: 5 additions & 0 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,13 @@
<li><a href="projects.html#php">PHP SDK</a></li>
<li><a href="projects.html#python">Python SDK</a></li>
<li class="divider"></li>
<li class="nav-header">Command line</li>
<li><a href="projects.html#powershell">PowerShell</a></li>
<li><a href="projects.html#cli">x-plat CLI</a></li>
<li class="divider"></li>
<li class="nav-header">More projects</li>
<li><a href="projects.html#iisnode">iisnode</a></li>
<li><a href="projects.html#teams">Other teams</a></li>
<li class="divider"></li>
<li class="nav-header">WindowsAzure.com</li>
<li><a href="//www.windowsazure.com/en-us/documentation/">Documentation Center</a></li>
Expand Down
Loading