Skip to content

change disableAlertingRulesAutoSelection default to be true #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benjaminhuo merged 1 commit into from
Feb 1, 2024
Merged

change disableAlertingRulesAutoSelection default to be true #457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/whizard/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ maintainers:
email: junhaozhang@kubesphere.io
- name: junot
email: junotxiang@kubesphere.io
version: 0.10.2
version: 0.10.3
appVersion: "latest"
4 changes: 2 additions & 2 deletions charts/whizard/crds/monitoring.whizard.io_services.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11881,9 +11881,9 @@ spec:
type: object
type: object
disableAlertingRulesAutoSelection:
default: false
default: true
description: "DisableAlertingRulesAutoSelection disable auto select
alerting rules in tenant ruler \n Default: false"
alerting rules in tenant ruler \n Default: true"
type: boolean
evaluationInterval:
default: 1m
Expand Down
4 changes: 2 additions & 2 deletions config/crd/bases/monitoring.whizard.io_services.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11881,9 +11881,9 @@ spec:
type: object
type: object
disableAlertingRulesAutoSelection:
default: false
default: true
description: "DisableAlertingRulesAutoSelection disable auto select
alerting rules in tenant ruler \n Default: false"
alerting rules in tenant ruler \n Default: true"
type: boolean
evaluationInterval:
default: 1m
Expand Down
4 changes: 2 additions & 2 deletions pkg/api/monitoring/v1alpha1/service_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,8 @@ type RulerTemplateSpec struct {

// DisableAlertingRulesAutoSelection disable auto select alerting rules in tenant ruler
//
// Default: false
// +kubebuilder:default:=false
// Default: true
// +kubebuilder:default:=true
DisableAlertingRulesAutoSelection *bool `json:"disableAlertingRulesAutoSelection,omitempty"`
}

Expand Down