Skip to content

Fix off by one error in v,o indexing for string refs #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evanmiller merged 1 commit into from
Mar 8, 2022
Merged

Fix off by one error in v,o indexing for string refs #270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/readstat_writer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,8 +604,8 @@ readstat_error_t readstat_insert_string_ref(readstat_writer_t *writer, const rea
return READSTAT_ERROR_STRING_REFS_NOT_SUPPORTED;

if (ref && ref->first_o == -1 && ref->first_v == -1) {
ref->first_o = writer->current_row;
ref->first_v = variable->index;
ref->first_o = writer->current_row + 1;
ref->first_v = variable->index + 1;
}

return writer->callbacks.write_string_ref(&writer->row[variable->offset], variable, ref);
Expand Down