Skip to content

Update project files with wporg files#154

Merged
Clorith merged 16 commits into
WordPress:masterfrom
Clorith:master
Feb 21, 2018
Merged

Update project files with wporg files#154
Clorith merged 16 commits into
WordPress:masterfrom
Clorith:master

Conversation

@Clorith
Copy link
Copy Markdown
Member

@Clorith Clorith commented Feb 16, 2018

PLEASE MERGE ME

This resets the project with the wporg-support theme that HelpHub was meant to build on top of, along with other dependencies.

Work in progress, PR is opened primarily for automated testing while files are being replaced, so that dependencies can be caught before everything is combined.

@ntwb
Copy link
Copy Markdown
Member

ntwb commented Feb 16, 2018

This is far too big a pull request for me to start reviewing at 7:30pm on a Friday night 🍷

I'll take a look over the weekend though 😄

@Clorith
Copy link
Copy Markdown
Member Author

Clorith commented Feb 16, 2018

Yeah, and I'm not entirely done yet either, that's just the basis, I need to spin it up as well now after moving the code around, just to make sure things are where they should be 😆

@Clorith
Copy link
Copy Markdown
Member Author

Clorith commented Feb 17, 2018

All right, that should be it, good to go 👍

Copy link
Copy Markdown
Member

@ntwb ntwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM, merge away 👍

@Clorith Clorith merged commit 5ac583d into WordPress:master Feb 21, 2018
felipeelia added a commit to felipeelia/HelpHub that referenced this pull request May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants