Add Content-* headers for empty POST requests#368
Conversation
|
As the author of #249 this looks good to me, not having actually run the code in several years. |
|
The HTTP method POST by definition contains an entity body. As such, the Content-Length request header must be set, or the entity body must be sent via HTTP/1.1 Transfer-Encoding: chunked (or HTTP/2). There are numerous prior tickets (#249, #318) and plenty of blog posts about this issue. Additionally, this bug reintroduced a bug fixed 12 years ago in Wordpress. https://core.trac.wordpress.org/ticket/8605 The patch in this PR is simple and looks reasonable, and this PR is over a year old. #249 is from 2016 (!) What is holding up actioning this PR, committing and releasing a fix? |
Signed-off-by: jrfnl <jrfnl@users.noreply.github.com>
…requests. Signed-off-by: jrfnl <jrfnl@users.noreply.github.com>
jrfnl
force-pushed
the
feature/249-318-add-content-headers-empty-post-requests
branch
from
1c2e6d4 to
890d048
Compare
schlessera
deleted the
feature/249-318-add-content-headers-empty-post-requests
branch
|
Thank you for picking this up, @schlessera, and thank you, @jrfnl, for jumping back in to quickly incorporate feedback to make the patch ready to merge. |
|
@gstrauss Case of striking the iron when it's hot and such ... 😀 |
5 participants
This PR consolidates the work done by @dd32 in PR #249 and @soulseekah in PR #318 which both addressed the same issue.
Fixes #248
Closes #249
Closes #318