Travis: fix PHP 8.0 build#461
Merged
Merged
Conversation
Even though we'll soon be moving to GH Actions, I think it is important to fix the failing build on PHP 8.0 ahead of this and ahead of the 1.8.0 release, as otherwise any badges in the README, on Packagist and on the website, will show the CI build as failing until we release version 2.0.0 and that wouldn't be right.
Codecov Report
@@ Coverage Diff @@
## master #461 +/- ##
============================================
- Coverage 93.06% 92.95% -0.12%
Complexity 764 764
============================================
Files 21 21
Lines 1788 1788
============================================
- Hits 1664 1662 -2
- Misses 124 126 +2
Continue to review full report at Codecov.
|
Member
Author
schlessera
approved these changes
Apr 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #439
Even though we'll soon be moving to GH Actions, I think it is important to fix the failing build on PHP 8.0 ahead of this and ahead of the 1.8.0 release, as otherwise any badges in the README, on Packagist and on the website, will show the CI build as failing until we release version 2.0.0 and that wouldn't be right.