Skip to content

Release 1.8.0#471

Merged
jrfnl merged 1 commit into
masterfrom
release/v1.8.0
Apr 27, 2021
Merged

Release 1.8.0#471
jrfnl merged 1 commit into
masterfrom
release/v1.8.0

Conversation

@schlessera
Copy link
Copy Markdown
Member

@schlessera schlessera commented Apr 17, 2021

No description provided.

@schlessera schlessera added this to the 1.8.0 milestone Apr 17, 2021
@schlessera schlessera changed the title Add first iteration on change log Release 1.8.0 Apr 17, 2021
@schlessera schlessera requested a review from jrfnl April 17, 2021 09:17
jrfnl
jrfnl requested changes Apr 18, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schlessera Hi Alain, thanks for writing this up! Looking good!

I'm missing a changelog entry for #238 (functional change).

Other than that, I've left various notes in-line. Nothing major.

For the future: would it be an idea to change to SemVer format starting with the 2.0.0 release ?

Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md
@schlessera
Copy link
Copy Markdown
Member Author

schlessera commented Apr 18, 2021

For the future: would it be an idea to change to SemVer format starting with the 2.0.0 release ?

Do you mean to announce the change (?) to semver on the roadmap here? Or are you talking about a specific format for the change log?

@schlessera schlessera requested a review from jrfnl April 18, 2021 07:20
@jrfnl
Copy link
Copy Markdown
Member

jrfnl commented Apr 18, 2021

Do you mean to announce the change (?) to semver on the roadmap here? Or are you talking about a specific format for the change log?

Sorry, no. I meant it as something to add to issue #460, if you agree, not for it to have any effect on this PR.
Was just a thought which came up while reviewing the PR.

jrfnl
jrfnl reviewed Apr 18, 2021
View reviewed changes
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
jrfnl
jrfnl reviewed Apr 18, 2021
View reviewed changes
Comment thread CHANGELOG.md
jrfnl
jrfnl reviewed Apr 18, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few more small remarks and responses to your replies. Other than that: all good!

@schlessera schlessera mentioned this pull request Apr 21, 2021
Closed
@schlessera schlessera marked this pull request as ready for review April 21, 2021 15:13
jrfnl
jrfnl approved these changes Apr 27, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@jrfnl jrfnl merged commit afbe479 into master Apr 27, 2021
@jrfnl jrfnl deleted the release/v1.8.0 branch April 27, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrfnl jrfnl jrfnl approved these changes

Assignees

No one assigned

Labels

Type: documentation Type: meta

Projects

None yet

Milestone

1.8.0

Development

Successfully merging this pull request may close these issues.

2 participants

@schlessera @jrfnl