GH Actions: see deprecations in all relevant workflows#777
Merged
Conversation
Follow up to PR 501 and in particular commit 1bb0e93. I honestly don't know why I initially added the ini setting changes only in the `test` workflow, but by rights, they should be in both the `test`, `quicktest` as well as the `lint` workflows. This commit fixes the omission. And if I'm touching these lines now anyway, I may as well also enable `zend.assertions=1` for the test workflows.
jrfnl
force-pushed
the
feature/ghactions-fix-missing-ini
branch
from
9695629 to
636fa34
Compare
schlessera
approved these changes
Nov 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to PR #501 and in particular commit 1bb0e93.
I honestly don't know why I initially added the ini setting changes only in the
testworkflow, but by rights, they should be in both thetest,quicktestas well as thelintworkflows.This commit fixes the omission.
And if I'm touching these lines now anyway, I may as well also enable
zend.assertions=1for the test workflows.