Fix empty secondary sidebar overlapping widget editor content on mobile viewports#38017
Merged
Merged
Conversation
talldan
added
[Type] Regression
talldan
requested review from
draganescu,
kevin940726,
nerrad,
noisysocks,
ntwb and
tellthemachines
as code owners
|
Size Change: +8 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
noisysocks
approved these changes
Jan 17, 2022
Member
noisysocks
left a comment
noisysocks
left a comment
There was a problem hiding this comment.
Code looks good. Thanks for adding a test!
noisysocks
pushed a commit
that referenced
this pull request
Jan 17, 2022
…le viewports (#38017) * Fix empty secondary sidebar overlapping widget editor content on mobile viewports * Add e2e test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #38002
It looks like the problem was introduced in #35706, when List View was added to the widgets editor.
The
InterfaceSkeletonrequires that a falsey value is passed as thesecondarySidebarprop to avoid rendering any secondary sidebar in the dom. The widgets editor code was always passing a react element by rendering<SecondarySidebar />, which evaluates to truthy. Even though thatSecondarySidebarcomponent wasn't displaying anything, an empty secondary sidebar would still be shown because of this.This issue only happens on mobile, I think the reason for that is a consequence of the styles—on desktop viewports the secondary sidebar collapses when there's no content, but on mobile it's always 100% width.
How has this been tested?
Types of changes
Regression
Checklist:
*.native.jsfiles for terms that need renaming or removal).