Add edit context to patterns REST controllers#40259
Merged
Merged
Conversation
ntsekouras
added
Core REST API Task
ntsekouras
requested review from
TimothyBJacobs and
spacedmonkey
as code owners
gziolo
approved these changes
Apr 12, 2022
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
Awesome, thank you for doing it.
In WordPress core I fight with some failing unit tests after similar changes. We should learn if that's the case here as well once CI jobs finish.
Member
|
I don't think we need to backport anything back to WP core from this PR - removed the label. |
jsnajdr
approved these changes
Apr 12, 2022
9 tasks
ntsekouras
force-pushed
the
update/pattern-controllers-edit-context
branch
from
6e43075 to
09fb87d
Compare
ntsekouras
force-pushed
the
update/pattern-controllers-edit-context
branch
from
09fb87d to
0a4d988
Compare
37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to add
editcontext to the patterns REST controllers as it has changed in the backport to core: WordPress/wordpress-develop#2567.This also adds a check about the theme's
patternsdirectory being readable and changeserrorsto_doing_it_wrongfor pattern registration from this theme's directory(patterns).