Add humanTimeDiff to @wordpress/date#41598
Closed
opr wants to merge 5 commits into
Closed
Conversation
ndiego
added
the
Needs Technical Feedback
vcanales
requested changes
Jul 15, 2022
Member
vcanales
left a comment
vcanales
left a comment
There was a problem hiding this comment.
This looks like something worth exposing through @wordpress/date. Thanks for including tests.
Comment on lines
+572
to
+575
| // Normalize inputs to a moment object, defaults to current time. | ||
| from = momentLib( from ); | ||
| to = momentLib( to ); | ||
| return from.from( to, ! includeAffix ); |
Member
There was a problem hiding this comment.
I think it's worth it, in order to avoid mutations and help readability, to define to and from as new constants with a distinct name.
Contributor
Author
There was a problem hiding this comment.
Thanks for the review. I agree!
I chose momentTo and momentFrom, do you have any better suggestions?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds a
humanTimeDifffunction to@wordpress/datealong with some tests.Why?
To allow the generation of a human-readable difference between timestamps that is available in Gutenberg. Also to fix #14486
How?
Using
moment'sfromutility we can generate the differences in their human readable format. This uses the locale supplied tomomentto generate the strings.Testing Instructions
npm run test) and ensure they pass.