Lodash: Refactor pascal case usages away from Lodash#42466
Merged
Conversation
tyxla
added
[Type] Performance
tyxla
requested review from
andrewserong,
aristath,
chad1008,
fabiankaegy,
jorgefilipecosta,
ntsekouras and
swissspidy
tyxla
requested review from
ajitbohra,
gziolo,
nerrad and
ryanwelcher
as code owners
|
Size Change: +784 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
tyxla
force-pushed
the
refactor/pascal-case-usages
branch
2 times, most recently
from
99f5352 to
7a64b73
Compare
tyxla
force-pushed
the
refactor/pascal-case-usages
branch
from
7a64b73 to
2085236
Compare
Member
Author
|
This could still use a review - does anyone have a chance to take a look? |
sgomes
approved these changes
Aug 10, 2022
Contributor
sgomes
left a comment
sgomes
left a comment
There was a problem hiding this comment.
The code LGTM 👍 There might be some differences between the way both libraries handle some strings, but they should be easy enough to handle if they pop up. The tests look good, though!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR removes a few
_.upperFirst( _.camelCase() )usages in favor ofchange-case'spascalCase(). This leaves a few more usages of both functions that we'll be addressing in a separate PR.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
Similar to #42427, we're suggesting to use the
change-caselibrary, which offers modular functions for all the casing functions we use from Lodash (likesnakeCase,capitalize,startCase,camelCase,kebabCase), at a small price (the methods are small themselves), and has TS support. The benefit of using that external library for all those case conversion functions is that we won't have to maintain our own versions of them, and those are already broadly used and tested.In particular, we replace a few of
_.upperFirst( _.camelCase() )Lodash usages in favor of thechange-caseone (pascalCase). We also replace a stray_.startCase()with its correspondingcapitalCase().Testing Instructions
npm run docs:genruns and completes without problems.npx @wordpress/create-block test-blockstill works well.