List v2: copy list wrapper when copying list items#42860
Merged
Conversation
ellatrix
added
[Type] Bug
|
Size Change: +183 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
Aug 15, 2022
Contributor
draganescu
left a comment
draganescu
left a comment
There was a problem hiding this comment.
This tests great! Tried the instructions also cross editors (GDoc, Pages, Plaintext) and works as expected.
I like this meta info in the clipboard :)
Member
|
I've found a couple of glitches with nested list (they can be looked at separately from this PR).
Gravacao.de.ecra.a.partir.de.15-08-2022.13.46.48.webm
Gravacao.de.ecra.a.partir.de.15-08-2022.13.47.11.webm |
Member
Author
Not sure what you'd expect here. The nested items are, well, nested to the item you're copying, so it seems appropriate? |
Member
Author
|
For the second item, it seems like the selection is wrong (based on the position of the toolbar).
|
Member
My expectation was that only the parent was copied. I can see why that happens (the nested are child of the item I selected) and it makes sense within the block editor interaction model (selects whole blocks). Though the behavior is different from what typical editors do (docs, office). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Currently when copying one or multiple list items (or all), they are copied with the list wrapper.
Why?
List items must be copied with a wrapper to be valid HTML.
Currently copied list items can't be pasted outside of lists.
How?
Signals to the copy handler that a wrapper block needs to be created by setting extra clipboard data.
Testing Instructions
Enable experimental list v2.
Create a list with list items. Select a single or a few list items. Copy them and paste them in an empty paragraph. What is pasted should be a list (including the correct attributes).
Screenshots or screencast