Rich text: remove splitting lines for deprecated multiline prop#43730
Closed
ellatrix wants to merge 3 commits into
Closed
Rich text: remove splitting lines for deprecated multiline prop#43730ellatrix wants to merge 3 commits into
ellatrix wants to merge 3 commits into
Conversation
|
Size Change: -91 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
ellatrix
changed the title
Contributor
|
I have learned that there are use cases where there are multiple In that case, one block cannot have multiple Personally, I feel that this migration would be burdensome for the developer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & Why?
This may be a little controversial. The
multilineprop was deprecated in #43613, but we do nothing more than logging a warning message and posting a dev note. Normally deprecated code lingers around in Gutenberg for a very long time. For this prop, my hope is that we don't have to keep it around for more that two WordPress releases, so I think some additional measures are in order.This PR disables creating new lines for multiline rich text instances, which hopefully pushes plugin authors to switch over to blocks quicker. You won't be able to create new paragraphs by pressing Enter. Instead, it will insert a line break (
<br>). You can still edit as HTML and insert another paragraph there if you really need to.Normal editing keeps working of course, only Enter is affected.
How?
Removal
Testing Instructions
Screenshots or screencast