[RNMobile] Add disabled prop to SwitchCell component#50560
Merged
Conversation
3 tasks
|
Size Change: 0 B Total Size: 1.39 MB ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR introduces a new disabled prop to the
SwitchCellcomponent.Why?
There are scenarios where we may need to prevent user interaction with the
SwitchCellcomponent. Introducing the disabled prop allows for this.How?
The disabled prop has been passed down to both the
CellandSwitchcomponents:Cellcomponent uses the disabled prop to prevent user interaction.Switchcomponent uses the disabled prop to prevent toggling, and also to change the default appearance of the switch.This change is backwards-compatible, as the disabled prop is optional and won't affect existing usage of
SwitchCell.Testing Instructions
The
ToggleControlcomponent makes use ofSwitchCell, so we can update a usage of it to test the new prop.Screenshots or screencast