Image: Mark connected controls as 'readonly'#59059
Merged
Merged
Conversation
Mamaduka
requested review from
artemiomorales and
michalczaplinski
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
added
[Type] Bug
|
Size Change: +118 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in fa0ea36. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7913169803
|
michalczaplinski
approved these changes
Feb 15, 2024
Contributor
michalczaplinski
left a comment
michalczaplinski
left a comment
There was a problem hiding this comment.
This tests fine for me! 👍
Fixes #58673
Member
Author
|
Thanks for testing, @michalczaplinski! |
Member
Author
|
@michalczaplinski, @afercia, does this need to be backported for WP 6.5? |
Contributor
|
Yes, I think it should! |
getdave
pushed a commit
that referenced
this pull request
Feb 20, 2024
* Image: Mark connected controls as 'readyonly' * Update e2e tests Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: michalczaplinski <czapla@git.wordpress.org> Co-authored-by: afercia <afercia@git.wordpress.org> # Conflicts: # test/e2e/specs/editor/various/block-bindings.spec.js
Contributor
|
I just cherry-picked this PR to the cherry-pick-beta-2 branch to get it included in the next release |
youknowriad
pushed a commit
that referenced
this pull request
Feb 20, 2024
* Image: Mark connected controls as 'readyonly' * Update e2e tests Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: michalczaplinski <czapla@git.wordpress.org> Co-authored-by: afercia <afercia@git.wordpress.org> # Conflicts: # test/e2e/specs/editor/various/block-bindings.spec.js
youknowriad
pushed a commit
that referenced
this pull request
Feb 20, 2024
* Image: Mark connected controls as 'readyonly' * Update e2e tests Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: michalczaplinski <czapla@git.wordpress.org> Co-authored-by: afercia <afercia@git.wordpress.org>
Contributor
|
I just cherry-picked this PR to the more/backports-for-beta3 branch to get it included in the next release: 974f545 |
youknowriad
added
the
Backported to WP Core
youknowriad
pushed a commit
that referenced
this pull request
Feb 20, 2024
* Image: Mark connected controls as 'readyonly' * Update e2e tests Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: michalczaplinski <czapla@git.wordpress.org> Co-authored-by: afercia <afercia@git.wordpress.org>
creativecoder
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes #58673.
PR updates connected attribute controls for the Image block to be marked as
readonlyinstead ofdisabled.Why?
See #58673.
Testing Instructions
See testing instructions from #58085.
Testing Instructions for Keyboard
Same.
Screenshots or screencast