Skip to content

Accordion Item and Panel: Remove layout from the block supports#72045

Merged
scruffian merged 2 commits into
trunkfrom
update/accordion-layout
Oct 3, 2025
Merged

Accordion Item and Panel: Remove layout from the block supports#72045
scruffian merged 2 commits into
trunkfrom
update/accordion-layout

Conversation

@scruffian
Copy link
Copy Markdown
Contributor

What?

Removes layout support from the Accordion Item and Accordion panel blocks, since its probably only really useful on the Accordion block itself.

Why?

These supports add complexity without adding value.

How?

Just remove from the block.json

Testing Instructions

  1. Add an accordion block and some content to it
  2. Check that there is noInner blocks use content width setting on the Accordion item or Accordion panel blocks

Screenshots or screencast

Screenshot 2025-10-03 at 11 14 42 Screenshot 2025-10-03 at 11 14 35

@scruffian scruffian self-assigned this Oct 3, 2025
@scruffian scruffian added [Type] Bug An existing feature does not function as intended [Block] Accordion Affects the Accordion Block labels Oct 3, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 3, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: scruffian <scruffian@git.wordpress.org>
Co-authored-by: mikachan <mikachan@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Comment thread packages/block-library/src/accordion-item/block.json Outdated
Copy link
Copy Markdown
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

Can we just remove the layout field, not define the false value? This is because I don't want the core block reference doc to show ~~layout~~ text.

Image

@scruffian
Copy link
Copy Markdown
Contributor Author

Can we just remove the layout field, not define the false value?

Done!

Copy link
Copy Markdown
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@scruffian scruffian enabled auto-merge (squash) October 3, 2025 10:44
@scruffian scruffian merged commit c770490 into trunk Oct 3, 2025
69 checks passed
@scruffian scruffian deleted the update/accordion-layout branch October 3, 2025 11:14
@github-actions github-actions Bot added this to the Gutenberg 21.9 milestone Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Accordion Affects the Accordion Block [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants