Accordion Heading: Remove the padding from the heading when it has a background color#72046
Merged
Conversation
scruffian
added
[Type] Bug
t-hamano
approved these changes
Oct 3, 2025
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the quick fix.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -684 B (-0.03%) Total Size: 1.95 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
Oct 3, 2025
ntsekouras
approved these changes
Oct 3, 2025
t-hamano
reviewed
Oct 3, 2025
| "padding": true | ||
| }, | ||
| "__experimentalSkipSerialization": true | ||
| "__experimentalSkipSerialization": true, |
Contributor
There was a problem hiding this comment.
Thank you, I forgot to skip serialization for padding.
|
I don't think this update makes sense as it's now not possible to add any padding as default styles from theme.json file. |
Contributor
|
Linking this issue #72776 for visibility |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Remove the padding from the Accordion heading block.
Why?
When the block has a background color, a padding applied from the heading element. We don't want that in the case as it is impossible override with the padding for this block.
How?
Using a stronger CSS selector to override the default padding
Testing Instructions
Screenshots or screencast