Patterns API: Fix the category_slugs format for featured patterns#711
Merged
ryelle merged 1 commit intoWordPress:trunkfrom Oct 1, 2024
Merged
Patterns API: Fix the category_slugs format for featured patterns#711ryelle merged 1 commit intoWordPress:trunkfrom
category_slugs format for featured patterns#711ryelle merged 1 commit intoWordPress:trunkfrom
Conversation
This fixes a regression caused via WordPress#704 that returns category_slugs as an object instead of an array
ryelle
approved these changes
Oct 1, 2024
Contributor
ryelle
left a comment
There was a problem hiding this comment.
Thanks for the fix and explanation!
This was referenced Oct 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression caused via #704 that returns
category_slugsas an object instead of an array for patterns that has thefeaturedcategory.This is breaking the Patterns tab in the block editor for all WP sites.
The modified array returned by
array_diff()can have non-consecutive indexes, causing it to be JSON-encoded as an object rather than array which is the expected format. Applyingarray_values()to the response fixes it."id": 199"category_slugs"attribute must be an array and not an object