CLI Runtime environment setup/cleanup

[jjgrainger]

Addresses acceptance criteria for #87

Closes #87

[jjgrainger]

Hi @felixarntz

I've setup a draft PR to review the changes here. I have the command working with the Runtime setup, however I think there is an opportunity to refactor some elements of the code here, in particular the latest additions to the Plugin_Check_Command.

Currently this uses the same logic found in the Admin_AJAX::get_checks_to_run() method to determine the checks to be run, if those checks can be run and filtering out runtime checks if the plugin is inactive.

I wasn't sure how best to solve this but my current thinking is we could potentially move a lot of this logic over to the Abstract_Check_Runner?

• The get_checks_to_run method could handle the additional logic to either remove runtime checks from the array or throw an exception if the plugin is inactive based on the checks requested.
• Rename the requires_universal_preparations method to has_runtime_check and make it public so it can be used in the Plugin_Check_Command to determine if we need to use the Runtime_Environment_Setup
• Update the logic for the Admin_AJAX to use a AJAX_Runner instance to handle returning the check slugs to run in the get_checks_to_run method.

Let me know your thoughts here. Thanks

[felixarntz]

@jjgrainger Thanks for pointing those out!

I agree with your points 1 and 3, it would be great if you could incorporate those changes.

Regarding point 2, I'm not sure about that one yet, it doesn't seem as appropriate, although I also agree with you we should avoid the duplicate logic. Maybe for now let's keep that one as is (i.e. acknowledge that we'll for now have the duplicate logic for the "has runtime check" concept), and we can revisit this as part of the architecture review.

[jjgrainger]

Thanks @felixarntz I've made the updates for 1 and 3. This is now ready for review.

[felixarntz]

@jjgrainger Mostly looks good including the refactoring, however a few things need to be fixed.

[felixarntz]

Thanks @jjgrainger, LGTM!

[mukeshpanchal27]

Thanks @jjgrainger, Left nit-pick.

[mukeshpanchal27]

Suggested change

	* Check for a Runtime_Check in a list of checks
	* Checks for a Runtime_Check in a list of checks.

[spacedmonkey]

I think this is close, I have some nicpics, otherwise this is looking good.

[spacedmonkey]

Created a number of follow on issues. But this is good to merge now.

[felixarntz]

Thanks @spacedmonkey!